Complicated relationship. I'm confused!

Can someone give some advice please?